Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroup - fix issue where button rounding doesn't align with toggle group border-radius #7238

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcfilben
Copy link
Collaborator

What does this PR do?

There is a slight gap in the rounding between the border of the ToggleGroup container and the buttons within. It is easiest to see this in the dark mode grommet theme. This PR fixes this so that there isn't a gap.
before:
Screen Shot 2024-05-21 at 12 16 11 PM
after:
Screen Shot 2024-05-21 at 12 35 06 PM

Where should the reviewer start?

What testing has been done on this PR?

How should this be manually tested?

Do Jest tests follow these best practices?

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Do the grommet docs need to be updated?

no

Should this PR be mentioned in the release notes?

yes

Is this change backwards compatible or is it a breaking change?

backwards compatible

@jcfilben jcfilben requested review from taysea and britt6612 May 21, 2024 19:29
@taysea
Copy link
Collaborator

taysea commented May 21, 2024

This solution seems to crop out the focus indicator.

Screen.Recording.2024-05-21.at.1.19.43.PM.mov

@jcfilben
Copy link
Collaborator Author

This solution seems to crop out the focus indicator.

Oops, good catch. Marking this PR as a draft. I'll have to think about other approaches we can take to solve this

@jcfilben jcfilben marked this pull request as draft May 21, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants