-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-visit hover state for primary button (e.g. currently there is no visual indicator other than a cursor change) #1271
Comments
Created a couple of ideations here : https://www.figma.com/proto/Oi5UEEQ33VCAyOKQcZ8Nr8/HPE-Button-Component?page-id=2282%3A5045&node-id=4243%3A9054&viewport=295%2C48%2C0.07&scaling=min-zoom&starting-point-node-id=4243%3A9054 |
I think the elevation approach aligns better with how we handle hover styling for Card. The border treatment doesn't seem as consistent with anything else we have in the design system currently. A couple of other ideas:
|
@ericsoderberghp Thank you so much for the feedback, I tried the options you have mentioned,
|
Nice to see more options.
I don't think we have to make the hover styling even more prominent than the primary button already is, in case that opens up some more possibilities. |
Hi @Keeth-HPe Thanks for providing all of these options! I think we should stick to a fairly straightforward approach here. I checked for accessibility and these colors pass the recommended color contrast ratios. In addition to the primary green button, I also went ahead and suggested hover states for the Color buttons (blue and purple). Let me know if you agree with this approach: Figma: https://www.figma.com/file/Oi5UEEQ33VCAyOKQcZ8Nr8/HPE-Button-Component?node-id=4401%3A9254 |
I agree with this approach 👍 @bahriaditi |
The problem with making the background colors our dark colors are that the text is now not legible. After running some accessibility tests, it looks like the light mode and dark mode for the primary button do not pass accessibility. We might want to look at other ways of showing hover for our primary color. Like perhaps we need to add a new tint for light mode and a tint for dark mode. Please read my other comments on the Figma file I as taking a peek at Carbon's Design System color palette and they have various of contrast. Now this is due to the fact that they offer other background colors in their theme. While we don't need to extend our color pallet to this extent, we should consider other tints and hues for our primary |
@vavalos5 great eye, as always! I missed checking for text legibility. @Keeth-HPe can you explore some more color options based on Vicky's comments please? I'll move this ticket back to "in progress" |
@Keeth-HPe Spoke to soon! Checked in with Vicky, and these colors do actually pass the WCAG AA guidelines based on results here: https://webaim.org/resources/contrastchecker/ Note that we are making one trade off with this approach:
|
Closing this, in v5 of the theme we added a hover gradient. |
No description provided.
The text was updated successfully, but these errors were encountered: