Resources component #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
The resource tiles should always have a white background as they're essentially a card so the content can read better within the accordion. Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com> # Conflicts: # src/develop/Develop.js # src/examples/Examples.js # src/scss/_objects.modules.scss
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
| description: 'Real Academia de Bellas Artes Ehances Experience with Mobile App' | ||
| } | ||
| ]} | ||
| /> | ||
| </AccordionPanel> | ||
| <AccordionPanel panelTitle="Software Licensings and Managment"> |
There was a problem hiding this comment.
Can you please fix the typo on this line? I tried fixing it but have no permission to write to your fork. Managment
There was a problem hiding this comment.
Fixed the typo, also added you as a collaborator to my fork
| </dl> | ||
| </section> | ||
|
|
||
| <section> |
There was a problem hiding this comment.
Can we list out the ResourcesTile's options here in details, similar to how the Tags/Tag components documentation in Grommet core?
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com>
Signed-off-by: Emmanuel Pilande <manny.pilande@hpe.com> # Conflicts: # src/examples/Examples.js
# Conflicts: # src/develop/Develop.js # src/scss/_objects.callout.scss # src/scss/_objects.modules.scss
|
A general question, is there a case where a ResourceTile is a link? It looks to me like these ResourceTiles should be clickable elements. If so, it does not look like the ResourceTile component supports that functionality in this PR, right? |
# Conflicts: # src/develop/Develop.js # src/examples/Examples.js # src/scss/_objects.modules.scss
|
@phuson agreed. Updated PR to make resource tiles clickable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource & Resource Tile component #32.
Also related to #20.
Screenshot of component:
