Fix for #9 #12
Closed
Fix for #9 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace invalid@invalid
|
superseded by gcf385b28a |
|
(gromox-2.18-76-gcf385b28a) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ugly hack but works. Perhaps the default behaviour of grommunio has changed since Kopano/Zarafa, since the code beginning "// Delete the PR_SENT_REPRESENTING_* properties" no longer works but looks like it was put there to solve this same problem. Maybe previously, an empty FROM was replaced in another component by the user's address, but it is now replaced with "invalid@invalid".
I consider this a bug. I note that Sogo, from which I moved from, covers this case correctly at the mime stage (https://github.com/Alinto/sogo/blob/1964ef03581947056807649fd46fa0d9a95f998e/ActiveSync/SOGoActiveSyncDispatcher.m#L3544). grommunio-sync doesn't directly parse the mime, and probably shouldn't, so my only idea was to replace the mapi properties on the resulting message. This will obviously no longer work if "invalid@invalid" ever changes.