Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for HTTPS #6

Closed
denilsonsa opened this issue Sep 22, 2014 · 5 comments
Closed

Fixes for HTTPS #6

denilsonsa opened this issue Sep 22, 2014 · 5 comments

Comments

@denilsonsa
Copy link
Contributor

If I try browsing Drawception using https://, instead of http://, then I get a warning on the console:

[blocked] The page at 'https://drawception.com/settings/' was loaded over HTTPS, but ran insecure content from 'http://chat.grompe.org.ru/jappix-mini.js': this content should also be loaded over HTTPS.

In addition, there might be some other warnings that I have not noticed yet (because I have just toggled to HTTPS, I haven't even tried to play a full game on it yet). Looking at *.user.js source-code, I can see a bunch of CSS backgrounds pointing to HTTP (instead of protocol-less URLs).

@grompe
Copy link
Owner

grompe commented Sep 22, 2014

The chat.grompe.org.ru domain doesn't support HTTPS yet.
As for CSS backgrounds, fair enough, will fix.

@denilsonsa
Copy link
Contributor Author

Meanwhile, you might want to disable embedding the chat if the chat is disabled in options. Or if it is HTTPS. But, at the same time, it might be too much trouble for little gain.

@grompe
Copy link
Owner

grompe commented Sep 22, 2014

Chat is embedded only if the respective setting is enabled. I'll leave it as is to support browsers that still allow HTTP resources on HTTPS version of the site.

@denilsonsa
Copy link
Contributor Author

You're right. I guess I received the warning because the storage for HTTP and HTTPS versions seems different, or because ANBT settings got reset for some reason (and thus the chat was being embedded automatically). Sorry for the noise. :)

@grompe
Copy link
Owner

grompe commented Sep 23, 2014

localStorage is indeed separate for HTTP and HTTPS domains.
I consider this issue resolved.

@grompe grompe closed this as completed Sep 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants