tmp

.github/workflows/ci.yaml

@@ -7,6 +7,8 @@ jobs:
         steps:
             -   uses: actions/checkout@v2
             -   uses: actions/setup-go@v2
+            -   name: Install dependencies
+                run: sudo apt update && sudo apt install libsnmp-dev
             -   name: Build
                 run: go build ./cmd/snmp-proxy
             -   name: Upload binaries
@@ -21,8 +23,8 @@ jobs:
         steps:
             -   uses: actions/checkout@v2
             -   uses: actions/setup-go@v2
-            -   name: Install pip3
-                run: sudo apt install python3-pip
+            -   name: Install dependencies
+                run: sudo apt update && sudo apt install libsnmp-dev python3-pip snmp-mibs-downloader
             -   name: Install snmpsim
                 run: sudo pip3 install snmpsim
             -   name: Run tests
@@ -34,8 +36,8 @@ jobs:
         steps:
             -   uses: actions/checkout@v2
             -   uses: actions/setup-go@v2
-            -   name: Install pip3
-                run: sudo apt install python3-pip
+            -   name: Install dependencies
+                run: sudo apt update && sudo apt install libsnmp-dev python3-pip snmp-mibs-downloader
             -   name: Install snmpsim
                 run: sudo pip3 install snmpsim
             -   name: Download go-acc

Makefile

@@ -24,5 +24,9 @@ test:
 	timeout 300 go test --race ./...
 	timeout 300 go test --count 100 ./...
 
+.PHONY: clean
+clean:
+	rm -rf bin
+
 $(BIN)/golangci-lint:
 	curl --retry 5 -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.27.0

cmd/snmp-proxy/snmp-proxy.go

@@ -24,6 +24,7 @@ func main() {
 	}
 
 	mibParser := snmpproxy.NewNetsnmpMibParser(config.Logger, config.Snmp.StrictMibParsing)
+
 	displayHints, err := mibParser.Parse()
 	if err != nil {
 		config.Logger.Fatalw("mib parser error: ", zap.Error(err))

snmpproxy/mib.go

@@ -53,6 +53,7 @@ func (p *NetsnmpMibParser) Parse() (DisplayHints, error) {
 	defer w.Close()
 
 	stderrFd := int(os.Stderr.Fd())
+
 	savedStderrFd, err := syscall.Dup(stderrFd)
 	if err != nil {
 		return nil, err
@@ -88,7 +89,7 @@ func (p *NetsnmpMibParser) Parse() (DisplayHints, error) {
 	// Restore stderr
 	_ = w.Close()
 	_ = syscall.Close(stderrFd)
-	syscall.Dup2(savedStderrFd, stderrFd)
+	_ = syscall.Dup2(savedStderrFd, stderrFd)
 	_ = syscall.Close(savedStderrFd)
 
 	if err := <-errChan; err != nil {

snmpproxy/mib_test.go

@@ -10,11 +10,15 @@ import (
 )
 
 func TestNetsnmpMibParser_Parse(t *testing.T) {
-	mibParser := snmpproxy.NewNetsnmpMibParser(zap.NewNop().Sugar(), true)
+	require := require.New(t)
+
+	mibParser := snmpproxy.NewNetsnmpMibParser(zap.NewNop().Sugar(), false)
 	displayHints, err := mibParser.Parse()
 
-	require.NoError(t, err)
-	require.Equal(t, snmpproxy.DisplayHints{}, displayHints)
+	require.NoError(err)
+	require.NotEmpty(displayHints)
+	require.Equal(snmpproxy.DisplayHintString, displayHints[".1.3.6.1.2.1.2.2.1.2"])
+	require.Equal(snmpproxy.DisplayHintHexadecimal, displayHints[".1.3.6.1.2.1.4.22.1.2"])
 }
 
 func TestMibDataProvider_GetStringType(t *testing.T) {