Skip to content

Commit

Permalink
Add TODO comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
s-yata committed Nov 17, 2014
1 parent 9f62e01 commit 453b22e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions include/grnxx/data_types/vector/bool.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ class Vector<Bool> {
constexpr Vector(const Bool *data, size_t size) : data_(data), size_(size) {}
explicit constexpr Vector(NA) : data_(nullptr), size_(NA()) {}

// TODO: The argument should be Int.
// Also, N/A should be returned for an invalid "i".
const Bool &operator[](size_t i) const {
return data_[i];
}
Expand Down
2 changes: 2 additions & 0 deletions include/grnxx/data_types/vector/float.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ class Vector<Float> {
size_(size) {}
explicit constexpr Vector(NA) : data_(nullptr), size_(NA()) {}

// TODO: The argument should be Int.
// Also, N/A should be returned for an invalid "i".
const Float &operator[](size_t i) const {
return data_[i];
}
Expand Down
2 changes: 2 additions & 0 deletions include/grnxx/data_types/vector/geo_point.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ class Vector<GeoPoint> {
size_(size) {}
explicit constexpr Vector(NA) : data_(nullptr), size_(NA()) {}

// TODO: The argument should be Int.
// Also, N/A should be returned for an invalid "i".
const GeoPoint &operator[](size_t i) const {
return data_[i];
}
Expand Down
2 changes: 2 additions & 0 deletions include/grnxx/data_types/vector/int.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ class Vector<Int> {
constexpr Vector(const Int *data, size_t size) : data_(data), size_(size) {}
explicit constexpr Vector(NA) : data_(nullptr), size_(NA()) {}

// TODO: The argument should be Int.
// Also, N/A should be returned for an invalid "i".
const Int &operator[](size_t i) const {
return data_[i];
}
Expand Down

0 comments on commit 453b22e

Please sign in to comment.