Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress -Wconversion warnings #1641

Open
kou opened this issue Dec 8, 2023 · 0 comments
Open

Suppress -Wconversion warnings #1641

kou opened this issue Dec 8, 2023 · 0 comments
Labels
Feature

Comments

@kou
Copy link
Member

kou commented Dec 8, 2023 •
edited

What is your problem?

We can enable -Wconversion by cmake -DGRN_WARN_CONVERSION=ON.

We need this to update bundled Groonga in MariaDB. MariaDB treats this warning as an error.

We should do this step by step. We must not open one large PR that includes all changes. We can't review it.

How to reproduce it

No response
@kou kou added the Feature label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kou