Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unittests #37

Merged
merged 2 commits into from Dec 13, 2020
Merged

add unittests #37

merged 2 commits into from Dec 13, 2020

Conversation

ledmonster
Copy link
Member

@ledmonster ledmonster commented Dec 13, 2020 •
edited

add unittests for this package.

  • use rospypi to install dependent modules in pure python environment
  • run dummy parameter server on unittest, because rosbridge_library calles rospy.get_param internally
  • configure circleci

ledmonster
ledmonster commented Dec 13, 2020
View reviewed changes
requirements.txt
msgpack-python>=0.4.8
paho-mqtt>=1.2
pymongo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use pymongo based bson library (#13)

This was referenced Dec 13, 2020
Closed
Closed
@ledmonster ledmonster merged commit 2b20c17 into master Dec 13, 2020
@ledmonster ledmonster deleted the feature/unittest branch December 13, 2020 16:22
@ledmonster ledmonster mentioned this pull request Dec 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ledmonster