Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord sometimes comments on old, inactive pull requests #166

Open
openjck opened this issue Dec 31, 2015 · 0 comments
Open

Discord sometimes comments on old, inactive pull requests #166

openjck opened this issue Dec 31, 2015 · 0 comments
Labels

Comments

@openjck
Copy link
Contributor

openjck commented Dec 31, 2015

Sometimes, while commenting on a new pull request, Discord will also comment on an old pull request that is completely unrelated. Sometimes this second pull request is from another project.

For example, imagine that the Kuma and Bedrock teams both use Discord. Imagine that one day, the Kuma team opens a pull request. Discord would comment on that pull request normally. Then imagine that the Bedrock team opens their own pull request a few weeks later. Discord would also comment on that pull request normally, but it might also go back and comment on the very old and unrelated Kuma pull request at the same time.

I'm really stumped by this. Discord should only be reacting to pull request activity. Nothing happening in project A should trigger Discord to comment on project B. I'm tempted to say this has something to do with Redis jobs getting stuck, and maybe it does, but I vaguely remember this happening before Redis was introduced.

@openjck openjck added the bug label Dec 31, 2015
@openjck openjck changed the title Discord sometimes comments on old pull requests Discord sometimes comments on old, unrelated pull requests Dec 31, 2015
@openjck openjck changed the title Discord sometimes comments on old, unrelated pull requests Discord sometimes comments on old, inactive pull requests Jan 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant