Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty Keyword search #16

Closed
skast96 opened this issue Jul 31, 2020 · 3 comments
Closed

Empty Keyword search #16

skast96 opened this issue Jul 31, 2020 · 3 comments

Comments

@skast96
Copy link

skast96 commented Jul 31, 2020

The empty keyword search for explores does not work. It causes a 400 Bad Request.
My guess is the keyword should be omitted if it is empty, but this does not happen.
@groovili
Copy link
Owner

groovili commented Aug 3, 2020

Hi @skast96 !
Google Trends API doesn't support explore empty keywords. Explore request always has urlencoded comparison item.
What you see on the main page of Google Trends is -
GET https://trends.google.com/trends/api/explore/examples?hl=ru&tz=-180
endpoint. But it's not updated and seems to rather be an example then general trends overview.

@groovili groovili closed this as completed Aug 3, 2020
@skast96
Copy link
Author

skast96 commented Aug 3, 2020

I fixed it in my fork. I am going to refactor my code for a nice pull request if you are interested in this feature..

@groovili
Copy link
Owner

groovili commented Aug 3, 2020

Sure! Don't forget to add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@groovili @skast96