Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it more obvious that Groovy 2.5 is optional #958

Closed
digulla opened this issue Sep 20, 2019 · 4 comments
Closed

Make it more obvious that Groovy 2.5 is optional #958

digulla opened this issue Sep 20, 2019 · 4 comments

Comments

@digulla
Copy link

digulla commented Sep 20, 2019

When installing the Groovy plugin from the Marketplace, the only available compiler is Groovy 2.5. There is little indication in the UI that the plugin comes with 2.4 and that 2.5 is purely optional which can lead to the InvalidRegistryObjectException issue described in #317

Please add " (optional; without this, you get 2.4)" or similar to the entry for 2.5 or add 2.4 as a mandatory dependency visible in the Marketplace client.

@eric-milles
Copy link
Member

This is what the update site looks like:
image

And this is what it looks like in the Marketplace listing:
image

Groovy 2.5 and Maven support have been marked as Optional for some time. I don't know what that looks like on the install client side. Maybe this is an issue for the Marketplace Client team to make Optional appear more clearly.

@digulla
Copy link
Author

digulla commented Sep 20, 2019

Here is how it looks in the Marketplace Client:

image

As you can see, 2.4 and 3.0 are not mentioned at all. This is very confusing.

How about setting the install state for 2.5 to "Optional" (not selected)?

@eric-milles
Copy link
Member

In your screenshot "Eclipse Groovy Development Tools" is marked "required". I make Groovy 2.5 optional, but selected because it is the current Groovy release.

@digulla
Copy link
Author

digulla commented Sep 20, 2019

How about making 2.4 visible and optional + deselected in this screen? That way, it wouldn't like you get nothing if you deselect 2.5 plus you can select 2.4 without 2.5 and avoid the InvalidRegistryObjectException issue when setting up a new workspace.

@groovy groovy locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants