Update lib/kennel/models/dashboard.rb

Co-authored-by: Michael Grosser <michael@grosser.it>
grosser · May 14, 2024 · 139ae12 · 139ae12
1 parent 59a0c5c
commit 139ae12
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/lib/kennel/models/dashboard.rb b/lib/kennel/models/dashboard.rb
@@ -196,14 +196,10 @@ def resolve_linked_tracking_ids!(id_map, **args)
               definition[:slo_id] = resolve(id, :slo, id_map, **args) || id
             end
           when "timeseries"
-            if requests = definition[:requests]
-              requests.map do |request|
-                next unless queries = request[:queries]
-                queries.map do |query|
-                  next unless query[:data_source] == "slo"
-                  if id = query[:slo_id]
-                    query[:slo_id] = resolve(id, :slo, id_map, **args) || id
-                  end
+            definition[:requests]&.each do |request|
+              request[:queries]&.each do |query|
+                if query[:data_source] == "slo" && (slo_id = query[:slo_id])
+                  query[:slo_id] = resolve(slo_id, :slo, id_map, **args) || slo_id
                 end
               end
             end