Skip to content

Commit

Permalink
Merge pull request #277 from grosser/grosser/legend
Browse files Browse the repository at this point in the history
dashboard show_legend defaults to false, so we need to be able to set…
  • Loading branch information
grosser committed Apr 26, 2023
2 parents c23c9bf + 702cc87 commit 1648c3b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion lib/kennel/models/dashboard.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ class Dashboard < Record
min: "auto",
max: "auto"
},
show_legend: true,
time: {},
title_align: "left",
title_size: "16"
Expand Down
2 changes: 1 addition & 1 deletion test/kennel/models/dashboard_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def resolve(force: false)

describe "with missing default" do
let(:json) { expected_json_with_requests }
before { json[:widgets][0][:definition][:show_legend] = true }
before { json[:widgets][0][:definition][:legend_size] = "0" }

it "ignores timeseries defaults" do
dashboard_with_requests.diff(json).must_equal []
Expand Down

0 comments on commit 1648c3b

Please sign in to comment.