Add support for time_slice slo #313

kaarolch · 2024-05-23T08:54:16Z

Add suport for time_slice SLO, that instead query use sliSpecification:

sli_specification {
    time_slice {
      query {
        formula {
          formula_expression = "query1"
        }
        query {
          metric_query {
            name  = "query1"
            query = "avg:my.custom.count.metric{*}.as_count()"
          }
        }
      }
      comparator = ">"
      threshold  = 0.9
    }

I'm a beginner at Ruby, so if some of my code isn't well-written, I would appreciate feedback.

Checklist

Verified against local install of kennel (using path: in Gemfile)
Added tests
Updated Readme.md (if user facing behavior changed)

lib/kennel/models/slo.rb

grosser

the importer needs to support it too

test/kennel/models/slo_test.rb

grosser · 2024-05-23T10:43:00Z

looks mostly right, thx for the PR
I can pair on this next week if you are getting stuck or spending >30m on this 👍

kaarolch · 2024-05-23T15:48:39Z

I will try to update imported this week / Mon. Thank for review and hints 👍

kaarolch · 2024-05-24T14:01:37Z

@grosser added sli_specification to importer, but still need to fix nesting conversion in sli_specification.

grosser · 2024-05-25T14:12:54Z

lib/kennel/importer.rb

@@ -19,10 +19,15 @@ def import(resource, id)
        raise(ArgumentError, "#{resource} is not supported")

      data = @api.show(model.api_resource, id)
+      # get sli specification before normalization.
+      sli_specification = data[:sli_specification] || data.dig(:sli_specification, :time_slice)


how can it be in 2 different places ?

... fixed this, we had some temp-fix code that added it to read-only :D

grosser · 2024-05-25T14:13:36Z

lib/kennel/models/slo.rb

@@ -35,7 +35,9 @@ def build_json
          type: type
        )

-        if v = query
+        if type == 'time_slice'
+          data[:sliSpecification] = :sli_specification


this needs to be the actual call ?

Suggested change

data[:sliSpecification] = :sli_specification

data[:sliSpecification] = sli_specification

grosser · 2024-05-25T14:36:54Z

fixing here #314

kaarolch added 2 commits May 23, 2024 08:55

Add support for time_slice slo

10e1eb0

Add SLO type verification

2725886