Add option to use TEST_ENV_NUMBER="1" for first process #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See README changes and discussion on #297 for motivation. The implementation allows for switching via either an environment variable or a command-line switch for the `parallel_test` executable, similar to `PARALLEL_TEST_PROCESSORS` and `-n`.
| @@ -24,6 +24,11 @@ def determine_number_of_processes(count) | |||
| ].detect{|c| not c.to_s.strip.empty? }.to_i | |||
| end | |||
|
|
|||
| def always_use_test_env_number_for_first_process? | |||
| val = ENV["PARALLEL_TEST_USE_TEST_ENV_NUMBER_FOR_FIRST_PROCESS"] | |||
|
test coverage looks good! |
(and related)
Make it private in CLI per review.
Per review.
|
Updated per discussion. Thanks for your feedback. I tried to repro the travis failures, but they don't happen for me locally. Are they expected? |
|
Looks like those tests didn't fail the second time around, so nothing to worry about 😃. Please let me know if you have any other feedback. |
grosser
added a commit
that referenced
this pull request
Jan 21, 2016
Add option to use TEST_ENV_NUMBER="1" for first process
|
Thanks! |
|
v2.3.0 is out! |
|
Awesome. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See README changes and discussion on #297 for motivation.
The implementation allows for switching via either an environment variable or a command-line switch for the
parallel_testexecutable, similar toPARALLEL_TEST_PROCESSORSand-n.The env var is
PARALLEL_TEST_USE_TEST_ENV_NUMBER_FOR_FIRST_PROCESSand the command line option is--use-test-env-number-for-first-process. I'm happy to change these to something less verbose.