Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test environment improvements #659

Merged
merged 12 commits into from
Oct 24, 2018
Merged

Test environment improvements #659

merged 12 commits into from
Oct 24, 2018

Commits on Oct 23, 2018

  1. Fix incorrect bundle config command 

    I was getting warnings on my system gems when running these specs, and
that seems not intended. By fixing this command, the warnings are moved
to vendor.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    49807ca View commit details
    Browse the repository at this point in the history

  2. Remove files that seem accidentally commited 

    Since they are only present on this fixture app.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    8498650 View commit details
    Browse the repository at this point in the history

  3. Fix gitignore to be like in the other fixture apps 

    In particular there's this **.orig entry that makes `rg` spit warnings
all around because it's not a valid gitignore entry, apparently.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    06a112d View commit details
    Browse the repository at this point in the history

  4. Run bundle update on fixture apps 

    To fix a bunch of warnings spit during tests. The rails50 app also
required bumping the minor version of Rails because the update
introduced some failures otherwise.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    7d7f454 View commit details
    Browse the repository at this point in the history

  5. Normalize minitest4 fixture app 

    Using the same criteria as in previous changes.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    1a04d59 View commit details
    Browse the repository at this point in the history

  6. Workaround similar to the following spec

    @deivid-rodriguez
    deivid-rodriguez committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    89d7e60 View commit details
    Browse the repository at this point in the history

  7. Make test less likely to have a race condition 

    The point of the test is to check that the signal is transmitted to all
subprocesses, so checking that none of the specs get run seems better?
This version seems to consistenly pass on my system.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    0b2636c View commit details
    Browse the repository at this point in the history

  8. Drop MRI 2.0.0 support from appveyor too

    @deivid-rodriguez
    deivid-rodriguez committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    90ef8c1 View commit details
    Browse the repository at this point in the history

  9. Remove other leftover from old versions

    @deivid-rodriguez
    deivid-rodriguez committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    7afd5e5 View commit details
    Browse the repository at this point in the history

  10. Skip possibily hanging spec on Windows

    @deivid-rodriguez
    deivid-rodriguez committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    506d6ba View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2018

  1. Fix new line char on Windows

    @deivid-rodriguez
    deivid-rodriguez committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    30e6ad8 View commit details
    Browse the repository at this point in the history

  2. Drop MRI 2.1 support too to get appveyor passing 

    It's apparently hitting a bug in bundler, but since 2.1 EOL'd, I don't
think it's worth caring.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    15d8138 View commit details
    Browse the repository at this point in the history