Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minitest 4 is dead #662

Merged
merged 1 commit into from
Oct 24, 2018
Merged

minitest 4 is dead #662

merged 1 commit into from
Oct 24, 2018

Conversation

grosser
Copy link
Owner

@grosser grosser commented Oct 24, 2018

@grosser grosser force-pushed the grosser/mini4 branch 3 times, most recently from e62a31f to 9645cd6 Compare October 24, 2018 04:07
@grosser grosser merged commit 4b5e0e2 into master Oct 24, 2018
@grosser grosser deleted the grosser/mini4 branch October 24, 2018 05:01
deivid-rodriguez
deivid-rodriguez reviewed Oct 24, 2018
View reviewed changes
spec/parallel_tests/test/runtime_logger_spec.rb
@@ -10,62 +10,6 @@ def run_tests
sh "ruby #{Bundler.root}/bin/parallel_test test -n 2"
end

it "writes a correct log on test-unit" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was dropping this intented? This is about test-unit, which seems supported? At least you have it on the Gemfile.

@grosser
Copy link
Owner Author

grosser commented Oct 24, 2018 via email

@deivid-rodriguez
Copy link
Contributor

I don't think many people is using it, but it seems actively maintained 👉 https://github.com/test-unit/test-unit

@grosser
Copy link
Owner Author

grosser commented Oct 24, 2018

afaik nobody should be using it ... let's see if anyone complains :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deivid-rodriguez deivid-rodriguez deivid-rodriguez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grosser @deivid-rodriguez