Add note about using the spring-commands-parallel-tests gem to automatically patch and enable Spring #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbroadbent
changed the title
ndbroadbent
changed the title
ndbroadbent
force-pushed
the
spring_info
branch
2 times, most recently
from
8303ae3
to
5bac97e
Compare
grosser
reviewed
Dec 7, 2019
ndbroadbent
force-pushed
the
spring_info
branch
from
5bac97e
to
74b77e2
Compare
…hing working with Spring
ndbroadbent
force-pushed
the
spring_info
branch
from
74b77e2
to
7c034cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to figure out why I couldn't get Spring to work, so I wanted to add this to the Readme and make it a bit clearer.
See #729 (comment)
EDIT: Actually I've realized that I am able to patch Spring to fix the database issue, and also set the default value of
DISABLE_SPRINGto"0"in myspring-commands-parallel-testsgem (since this code runs before parallel_tests.) So I might just update the README with instructions to use this gem, if that's ok!