Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against newest rubies on Windows #751

Merged
merged 10 commits into from Feb 24, 2020
Merged

Test against newest rubies on Windows #751

merged 10 commits into from Feb 24, 2020

Conversation

deivid-rodriguez
Copy link
Contributor

I had trouble getting these to work under Appveyor, so I migrated Windows CI to use Github Actions.

@grosser
Copy link
Owner

grosser commented Feb 17, 2020

how do you see the test output ? ... no new check appears here :(

@deivid-rodriguez
Copy link
Contributor Author

Oh, sorry, I should've explained. You need to enable actions on this repo. I think you need to go to either the "Actions" tab in the repo, or some tab under "Settings".

@deivid-rodriguez
Copy link
Contributor Author

I think these are the docs you need: https://help.github.com/en/actions/building-and-testing-code-with-continuous-integration/setting-up-continuous-integration-using-github-actions. In this case, you should choose "Configure a workflow yourself" in the top right corner of the "Actions" tab.

@grosser
Copy link
Owner

grosser commented Feb 24, 2020

I went through the setup and then added the windows.yml from this PR ... can you squash and then rebase to see if it works ?

To fix

```
d:/rubyinstaller-2.7.0-1-x64/lib/ruby/gems/2.7.0/gems/rake-12.0.0/lib/rake/application.rb:378: warning: deprecated Object#=~ is called on Proc; it always returns nil
```
To fix

```
d:/rubyinstaller-2.7.0-1-x64/lib/ruby/gems/2.7.0/gems/json-2.0.2/lib/json/common.rb:156: warning: Using the last argument as keyword parameters is deprecated
```
Since on Windows, the result seems consistent from ruby 2.4.
Since they still seem to hang sometimes.
This reverts commit 1aee2d2.
@grosser grosser merged commit 68f91f5 into grosser:master Feb 24, 2020
@grosser
Copy link
Owner

grosser commented Feb 24, 2020

I guess we could also consolidate travis to github actions now 🤷‍♂
... travis also has windows builds, so we could have used that too ...
https://docs.travis-ci.com/user/reference/windows/

@deivid-rodriguez deivid-rodriguez deleted the test_against_27 branch February 24, 2020 20:05
@deivid-rodriguez
Copy link
Contributor Author

Thanks, yeah, makes sense to consolidate everything in a single CI. I didn't know TravisCI had Windows.

@deivid-rodriguez
Copy link
Contributor Author

Now you can remove appveyor from the repo setup so it doesn't appear in the PR checks, and then remove the appveyor.yml file.

@grosser
Copy link
Owner

grosser commented Feb 24, 2020 via email

@deivid-rodriguez
Copy link
Contributor Author

Nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants