New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against newest rubies on Windows #751
Conversation
how do you see the test output ? ... no new check appears here :( |
Oh, sorry, I should've explained. You need to enable actions on this repo. I think you need to go to either the "Actions" tab in the repo, or some tab under "Settings". |
I think these are the docs you need: https://help.github.com/en/actions/building-and-testing-code-with-continuous-integration/setting-up-continuous-integration-using-github-actions. In this case, you should choose "Configure a workflow yourself" in the top right corner of the "Actions" tab. |
I went through the setup and then added the windows.yml from this PR ... can you squash and then rebase to see if it works ? |
To fix ``` d:/rubyinstaller-2.7.0-1-x64/lib/ruby/gems/2.7.0/gems/rake-12.0.0/lib/rake/application.rb:378: warning: deprecated Object#=~ is called on Proc; it always returns nil ```
To fix ``` d:/rubyinstaller-2.7.0-1-x64/lib/ruby/gems/2.7.0/gems/json-2.0.2/lib/json/common.rb:156: warning: Using the last argument as keyword parameters is deprecated ```
Since on Windows, the result seems consistent from ruby 2.4.
Since they still seem to hang sometimes.
This reverts commit 1aee2d2.
I guess we could also consolidate travis to github actions now 🤷♂ |
Thanks, yeah, makes sense to consolidate everything in a single CI. I didn't know TravisCI had Windows. |
Now you can remove appveyor from the repo setup so it doesn't appear in the PR checks, and then remove the appveyor.yml file. |
already removed the hook :)
…On Mon, Feb 24, 2020 at 12:07 PM David Rodríguez ***@***.***> wrote:
Now you can remove appveyor from the repo setup so it doesn't appear in
the PR checks, and then remove the appveyor.yml file.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#751?email_source=notifications&email_token=AAACYZ5UHH4LSHG5Q5QCUJDREQSILA5CNFSM4KWD47C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMZLAZY#issuecomment-590524519>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACYZ3M4AA5IBR4HHSHEVLREQSILANCNFSM4KWD47CQ>
.
|
Nice :) |
I had trouble getting these to work under Appveyor, so I migrated Windows CI to use Github Actions.