Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out region-specific functions and variable #17

Closed
xamanu opened this issue Sep 18, 2016 · 3 comments
Closed

Factor out region-specific functions and variable #17

xamanu opened this issue Sep 18, 2016 · 3 comments

Comments

@xamanu
Copy link
Contributor

xamanu commented Sep 18, 2016

There are some function calls and variable names in Portuguese language. I have spotted them primarily in the osm_routes.py file. These should be cleaned up.

@grote
Copy link
Owner

grote commented Sep 18, 2016

This is related to #9, maybe even a duplicate. I used non-english names for region-specific variables and methods. One idea is that region specific plugins/modules extend these classes and add their custom variables and methods to these sub-classes.

@grote grote changed the title Remove portuguese functions and variable Factor out region-specific functions and variable Sep 18, 2016
@xamanu
Copy link
Contributor Author

xamanu commented Oct 1, 2016

Yes, indeed this is a duplicate because the proposed changed in #9 would move those into a special Fenix class, where this can still be living in and makes sense there.

@xamanu xamanu closed this as completed Oct 1, 2016
@xamanu
Copy link
Contributor Author

xamanu commented Nov 19, 2016

Tackled now in #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants