Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Fenix specific code to Fenix classes #40

Closed
grote opened this issue Nov 7, 2016 · 5 comments
Closed

Move Fenix specific code to Fenix classes #40

grote opened this issue Nov 7, 2016 · 5 comments
Assignees

Comments

@grote
Copy link
Owner

grote commented Nov 7, 2016

No description provided.

@grote grote self-assigned this Nov 7, 2016
@pantierra
Copy link
Contributor

Cool. This would be great support in preparation of #30.

@pantierra
Copy link
Contributor

After pull request #43 I see almost all functions in Stop, Route, RouteMaster and BaseRoute to be Fenix specific.

Only those one's aren't Fenix specific:

Stop.get_center_of_nodes()
Route.print_shape_for_leaflet()

And probably we want to implement one more generic function like:

Route.get_stop_by_position(int) instead of Route.get_first_stop()

@pantierra
Copy link
Contributor

After pull request #44 (Default implementation for stops creation): If TripsCreatorFenix logic implemented pulling Stop objects from data.stops based on the stop ids in Route.stops, then Fenix could use the default StopsCreator implementation and get rid of the StopsCreatorFenix 👍

@grote
Copy link
Owner Author

grote commented Nov 19, 2016

Route.print_shape_for_leaflet()

This one is actually just a debugging function that I used during development. You can show the route on a leaflet map and inspect it in detail. Do you think we should keep this?

And probably we want to implement one more generic function like:

Route.get_stop_by_position(int) instead of Route.get_first_stop()

Yup, that's fine with me. Would be a fairly small pull request.

@pantierra
Copy link
Contributor

Route.print_shape_for_leaflet()

This one is actually just a debugging function that I used during development. You can show the route on a leaflet map and inspect it in detail. Do you think we should keep this?

I actually was thinking about creating a Debug class for this and more debug functionality. Here is a separate issue for this: #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants