Remove unused stops and routes #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xamanu
approved these changes
Feb 25, 2018
grote
reviewed
Feb 26, 2018
| @@ -41,6 +41,19 @@ def add_stops_to_feed(self, feed, data): | |||
| # Add stop to feed | |||
| gtfs_stop_id = self._add_stop_to_feed(stop, feed) | |||
|
|
|||
| def remove_unused_stops_from_feed(self, feed): | |||
There was a problem hiding this comment.
Could you maybe add a docstring here and above that explains when this method is called?
That's right, it removes them right away. But why would one prefer to have them blowing up the filesize? But as stated above, for #118 I could introduce another argument switch to turn this behavior of removing off? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to remove unused stops and routes from the final GTFS file. In order to allow #118, there could be easily added an argument switch.