You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
grote
merged 1 commit into
grote:master
from
xamanu:issue-9Oct 2, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces a creator classes for each part of the GTFS feed (agency, feed_info, routes, stops and trips).
A new CreatorFactory allows to overwrite default implementations of each individual creator based on naming convention from the selector property of the config file.
No existing logic has been touched, in order to keep pull requests as small as possible. Discussions about logic should go into the two issues about data structure #30 and refactoring the OsmHelper #31.
There are working default implementations for agency and feed_info because these were already (somehow) generic based on values from the config file.
But there are still no default implementations for routes, stops and trips as their current code exclusively works for the Fenix (Florianópolis) network (issues #26 and #27 will handle this). The default creator classes only define the basic functions that those creator are required to implement.
xamanu
changed the title
#9 - Factory based abstracted schedule creating
#9 - Factory based abstracted schedule creation
Oct 2, 2016
Thanks for this! I think this step-size is indeed more manageable to merge. Just too bad we lost so much time yesterday when you were flying blind ;)
Did you see my comment on the old PR about the creator directory structure? Would it be nicer to just have one creators folder with a subfolder for each region?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xamanu
changed the title
This pull request introduces a creator classes for each part of the GTFS feed (agency, feed_info, routes, stops and trips).
A new
CreatorFactoryallows to overwrite default implementations of each individual creator based on naming convention from the selector property of the config file.No existing logic has been touched, in order to keep pull requests as small as possible. Discussions about logic should go into the two issues about data structure #30 and refactoring the OsmHelper #31.
There are working default implementations for agency and feed_info because these were already (somehow) generic based on values from the config file.
But there are still no default implementations for routes, stops and trips as their current code exclusively works for the Fenix (Florianópolis) network (issues #26 and #27 will handle this). The default creator classes only define the basic functions that those creator are required to implement.