Add config file for Managua, Nicaragua network #88
Conversation
| "publisher_url": "https://mapanica.net", | ||
| "version": "0.1", | ||
| "start_date": "20171101", | ||
| "end_date": "20181031" |
There was a problem hiding this comment.
version, start_date and end_date should be set by timetable.json, but can stay here too.
There was a problem hiding this comment.
I'm not sure about this - for me they are more important in the config file, than in the data source. See comment here and following. The state of the discussion was to allow both.
There was a problem hiding this comment.
Okay, perfect. Thanks for the explanation! Leave it here then 😄
| }, | ||
| "timetable": "https://raw.githubusercontent.com/mapanica/pt-data-managua/master/timetable.json", | ||
| "output_file": "data/ni-managua-gtfs.zip", | ||
| "selector": "irtramma" |
There was a problem hiding this comment.
Why did you choose an folder named "managua"? We were using "irtramma", and I'm almost certain you should then change the selector too (or isn't it necessary at all while using default creator?)
There was a problem hiding this comment.
Hm, I use Managua since quite some time, because more people can understand what Managua is, rather than IRTRAMMA. Generally I would prefer to have a comprehensive list in the folders for the creators, like proposed also in this pull request here. Something like ni-managua or even ni-managua-irtramma.
Indeed, as you indicate, it is not necessary to change any selector's name, because managua is using the default creators.
|
Thanks for the review, @ialokim! |
|
Is this functional before the default creators have been merged? If not, should we hold off with merging it until they have been merged? |
|
Yes, this should wait until the default creators are merged in. Changed description accordingly. |
|
Included into #99. Closing. |
This is the simple config file for the Managua network. As this is going to use the default creators (#26, #27, #33) there is not more needed than merging them in. This PR is similar to #92 and should be merged in after:
The reason for posting it here, is because this is already working in local setups and should be in the pipeline to get into upstream.