Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messaging options not being set #42

Open
battis opened this issue Jul 13, 2023 · 2 comments
Open

messaging options not being set #42

battis opened this issue Jul 13, 2023 · 2 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@battis
Copy link
Member

battis commented Jul 13, 2023

#12 seems to be less closed than I thought, need to include the current setting that's being reset in the context, and double-check the documentation to make sure I'm not missing a "save" step.

@battis battis added the bug Something isn't working label Jul 13, 2023
@battis battis self-assigned this Jul 13, 2023
battis added a commit that referenced this issue Jul 13, 2023
Shown in context as “old setting”:”new settings”. Currently showing as “”: “NONE”. None is the desired setting, “” is _not_ what I expected it to be. Gotta read some documentation. #42
battis added a commit that referenced this issue Oct 11, 2023
@battis
Copy link
Member Author

battis commented Oct 11, 2023

Appears that listMembers() returns an array of Member-like objects, but not actually members. They are missing the delivery_settings field. Which means that to get the delivery settings for each member, each member would need to be individually queried per group, which is prohibitively resource expensive.

https://api.github.com/groton-school/blackbaud-to-google-group-sync/blob/6c30da3acbb2f3f1756fa7df850b0dc4daa18750/src/server/Workflows/sync.php#L125

            /*
            if ($gMember->getDeliverySettings() != $deliverySettings) {
                $oldDeliverySettings = $gMember->getDeliverySettings();
                $gMember->setDeliverySettings($deliverySettings);
                $gMember = $directory->members->update(
                    $bbGroup->getParamEmail(),
                    $gMember->getId(),
                    $gMember
                );
                $listProgress->setStatus(
                    "Updated {$gMember->email} delivery_settings from to '{$gMember->getDeliverySettings()}'"
                );
            }
            */

@battis battis mentioned this issue Oct 11, 2023
Closed
@battis
Copy link
Member Author

battis commented Oct 11, 2023

At the moment, no longer checking existing member's delivery settings, but setting new members delivery settings. This holds until the delivery settings on a group are changed in Blackbaud, necessitating the update of the members' delivery settings in Google, and -- likewise -- does not check for changes in Google that don't match the existing Blackbaud setting.

For our current use cases, this is mostly safe, but annoying.

@battis battis added the wontfix This will not be worked on label Oct 11, 2023
@battis battis mentioned this issue Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant