Starting a ValueObservation keeps a strong reference on the database connection. #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a build error when running tests with Xcode 13.3: error: Cycle inside GRDBiOS; building could produce unreliable results. This usually can be resolved by moving the target's Headers build phase before Compile Sources.
groue
force-pushed
the
dev/strong-observation
branch
from
3f7154b
to
6236b8a
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a change which is between the bugfix and the (small) breaking change.
Starting a
ValueObservationnow retains the database connection. This means that a database connection won't be deallocated, and won't close, until all observations are stopped (cancelled). As before, starting an observation returns a cancellable which automatically cancels the observation when it is deallocated.This change removes one difference between
ValueObservationandSharedValueObservation.It was also an opportunity to refactor the inner guts of ValueObservation, which is one of the most complex parts of GRDB. The new implementation is less fancy, more boring, with a smaller api surface, and hopefully easier to maintain.