Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc issue on TableRequest.filter(keys:). #1217

Merged
merged 1 commit into from May 16, 2022

Conversation

GetToSet
Copy link
Sponsor Contributor

@GetToSet GetToSet commented May 7, 2022

I'm working with GRDB.swift on my own app and after hitting the fatalError on TableRequest.filter(keys:), I found a minor issue on its documentation.

  • Should be AND on the SQL statement.

Pull Request Checklist

  • CONTRIBUTING: You have read https://github.com/groue/GRDB.swift/blob/master/CONTRIBUTING.md
  • BRANCH: This pull request is submitted against the development branch.
  • DOCUMENTATION: Inline documentation has been updated.
  • DOCUMENTATION: README.md or another dedicated guide has been updated.
  • TESTS: Changes are tested.
  • TESTS: The make smokeTest terminal command runs without failure.

@groue
Copy link
Owner

groue commented May 7, 2022

Thank you @GetToSet!

Please wait until I come back from vacations, in one week, until I merge your contribution 🙂

@groue groue merged commit 096a3b2 into groue:development May 16, 2022
@groue
Copy link
Owner

groue commented May 16, 2022

Thank you!

@GetToSet GetToSet deleted the development branch May 16, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants