Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for strict tables #1288

Merged
merged 5 commits into from Oct 20, 2022
Merged

Support for strict tables #1288

merged 5 commits into from Oct 20, 2022

Conversation

jcavar
Copy link
Contributor

@jcavar jcavar commented Oct 19, 2022

Resolves #1287

Pull Request Checklist

  • CONTRIBUTING: You have read https://github.com/groue/GRDB.swift/blob/master/CONTRIBUTING.md
  • BRANCH: This pull request is submitted against the development branch.
  • DOCUMENTATION: Inline documentation has been updated.
  • DOCUMENTATION: README.md or another dedicated guide has been updated.
  • TESTS: Changes are tested.
  • TESTS: The make smokeTest terminal command runs without failure.

groue
groue requested changes Oct 19, 2022
View reviewed changes
Copy link
Owner

@groue groue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jcavar :-) This looks very good.

During the refactoring, one test was lost, and I think we should restore it.

Tests/GRDBTests/TableDefinitionTests.swift Outdated Show resolved Hide resolved
@groue
Copy link
Owner

groue commented Oct 20, 2022

I took the liberty to apply the necessary fixes. Also, the test is now skipped for SQLCipher 3.

@groue
Copy link
Owner

groue commented Oct 20, 2022

OK, tests pass 👍 Thank you very much @jcavar, I'll prepare a release shortly.

@groue groue merged commit 6caa27c into groue:development Oct 20, 2022
@groue groue changed the title Add support for .strict table option in 3.37+ Support for strict tables Oct 20, 2022
@jcavar
Copy link
Contributor Author

jcavar commented Oct 20, 2022

Hey @groue, sorry, I am little slower.

Indeed, I've probably deleted the most useful part of the strict tables test.

Thanks for fixing it for me and thank you for your great work on this library!

@groue
Copy link
Owner

groue commented Oct 21, 2022

You're welcome, and happy GRDB :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groue groue groue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcavar @groue