Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sendable conformances and unavailabilities #1510

Merged
merged 3 commits into from Mar 17, 2024

Conversation

groue
Copy link
Owner

@groue groue commented Mar 17, 2024

This pull request adds or removes Sendable conformance to as many types as possible.

Some types are explicitly non-sendable. For example Database must be used from a database access method such as read or write, and will never become Sendable.

Some other types are left without any explicit annotation. Those will become sendable in GRDB 7. Some apps are able to add @unchecked Sendable conformance to some of them, when mandatory, under some specific conditions that should be checked in this discussion.

Either added, either made explicitly unavailable.
@groue
Copy link
Owner Author

groue commented Mar 17, 2024

cc @simba909: this PR completes your #1503 as far as GRDB 6 can go. For the record, I could find the exhaustive list of public types by building the DocC documentation from the GRDB SPM package, and looking for types in the built documentation:

$ find ~/Library/Developer/Xcode/DerivedData/GRDB-dbuvchqinknqzidnxbiauivgvrrm/Build/Products/Debug/GRDB.doccarchive/data/documentation/grdb -type d | sed "s/^.*grdb// | sort"
/adaptedfetchrequest
/aggregatingrequest
/allcolumns
...

@groue groue merged commit 9b95dd5 into development Mar 17, 2024
21 checks passed
@groue groue deleted the dev/trivial-sendable-conformances branch March 17, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant