New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a tiny typo #952
Fix a tiny typo #952
Conversation
Thank you @holsety ! That is indeed very straightforward. 🙂 |
Thanks to both of you :-) |
Sure thing. I hope it's ok to just go ahead for typos etc. as long as I'm minding the checklist. BTW, @groue , I figured I don't need to worry about Travis failing as long as the project's tests are working? |
The current Travis setup is... painful. SQLCipher tests, particularly, timeout very easily. I often have to restart jobs. So, ideally, everything is green. But it ends up red most of the time. On pull requests that do not change code, we can ignore Travis. On pull requests that do change code, running tests is very important, and I inspect Travis failures. |
Gentle contributors very often check everything in the checklist, even when it is not relevant, even when the pull request does not include the checked element. This has not created any real problem, though. The important checkbox is "This pull request is submitted against the |
Thanks again for the guidance and explanation! Good to know about the possible timeouts. I've been looking through the Travis logs earlier but couldn't quite make sense of everything.
This matches my expectation. Thanks for clarifying!
I have been very thorough to keep an I on the target branch. 👍 |
Thanks for your patience, @MartinP7r :-) Many of my release practices are undocumented. I'll answer your questions if you have any, and we may find opportunities to clarify/strengthen some critical steps. Meanwhile, here are a few commands that you may find useful one day:
|
Thank's for the pointer! That is some extensive Makefile you've got there 😳 |
There's a lot of configurations to check! |
This is a little typo when I try to copy them from the summary doc, it would be very straight forward :)
Pull Request Checklist
development
branch.