Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a tiny typo #952

Merged
merged 1 commit into from Apr 4, 2021
Merged

Fix a tiny typo #952

merged 1 commit into from Apr 4, 2021

Conversation

holsety
Copy link
Contributor

@holsety holsety commented Apr 4, 2021

This is a little typo when I try to copy them from the summary doc, it would be very straight forward :)

Pull Request Checklist

  • This pull request is submitted against the development branch.
  • Inline documentation has been updated.
  • README.md or another dedicated guide has been updated.
  • Changes are tested.

@MartinP7r
Copy link
Collaborator

Thank you @holsety ! That is indeed very straightforward. 🙂

@MartinP7r MartinP7r merged commit 5d14b3d into groue:development Apr 4, 2021
@groue
Copy link
Owner

groue commented Apr 5, 2021

Thanks to both of you :-)

@MartinP7r
Copy link
Collaborator

MartinP7r commented Apr 5, 2021

Sure thing. I hope it's ok to just go ahead for typos etc. as long as I'm minding the checklist.

BTW, @groue , I figured I don't need to worry about Travis failing as long as the project's tests are working?

@groue
Copy link
Owner

groue commented Apr 5, 2021

I figured I don't need to worry about Travis failing as long as the project's tests are working?

The current Travis setup is... painful. SQLCipher tests, particularly, timeout very easily. I often have to restart jobs. So, ideally, everything is green. But it ends up red most of the time.

On pull requests that do not change code, we can ignore Travis.

On pull requests that do change code, running tests is very important, and I inspect Travis failures.

@groue
Copy link
Owner

groue commented Apr 5, 2021

Sure thing. I hope it's ok to Judy go ahead for typos etc. as long as I'm minding the checklist.

Gentle contributors very often check everything in the checklist, even when it is not relevant, even when the pull request does not include the checked element. This has not created any real problem, though.

The important checkbox is "This pull request is submitted against the development branch" (because master contains the latest release, and its documentation). This checkbox most often has the desired effect: people submit against the development branch.

@MartinP7r
Copy link
Collaborator

Thanks again for the guidance and explanation!

Good to know about the possible timeouts. I've been looking through the Travis logs earlier but couldn't quite make sense of everything.

On pull requests that do not change code, we can ignore Travis.
On pull requests that do change code, running tests is very important, and I inspect Travis failures.

This matches my expectation. Thanks for clarifying!

The important checkbox is "This pull request is submitted against the development branch" (because master contains the latest release, and its documentation).

I have been very thorough to keep an I on the target branch. 👍

@groue
Copy link
Owner

groue commented Apr 5, 2021

Thanks for your patience, @MartinP7r :-) Many of my release practices are undocumented. I'll answer your questions if you have any, and we may find opportunities to clarify/strengthen some critical steps.

Meanwhile, here are a few commands that you may find useful one day:

@MartinP7r
Copy link
Collaborator

Thank's for the pointer! That is some extensive Makefile you've got there 😳

@groue
Copy link
Owner

groue commented Apr 5, 2021

There's a lot of configurations to check!

@holsety holsety deleted the tiny/typo branch April 6, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants