Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add support for Kubernetes versions <= v1.23 #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pega-talba
Copy link

In k8s-wait-for version 2.0, support was dropped for Kubernetes versions 1.23 and earlier. (See https://github.com/groundnuty/k8s-wait-for/releases/tag/v2.0 and #60)

After reviewing the code, it would be simple to continue to support earlier versions. Because we do not care about the Ready value, we do not need to explicitly capture the digit; instead, we can capture the whole (0 Ready) string zero or one times. We then ignore the captured value, as we do today.

I do appreciate the desire to push people to the latest releases of Kubernetes, but in this case, I believe the extra code required is minimal. It also this simplifies our ability to use the project when we cannot reliably know what k8s version is being used, and prevents people from being locked on k8s-wait-for 1.x.

Changes:

  • Updated the regular expression used by sed, to capture the full Ready statement
  • Updated README to account for this change, as consumers would no longer need to use k8s-wait-for 1.x
  • Fixed comment typos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant