This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleonard
reviewed
Nov 22, 2021
bleonard
reviewed
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misunderstanding about date vs. datetime concepts. trying to clarify.
plugins/@grouparoo/braze/src/lib/export/destinationMappingOptions.ts
Outdated
Show resolved
Hide resolved
plugins/@grouparoo/marketo/src/lib/export/destinationMappingOptions.ts
Outdated
Show resolved
Hide resolved
evantahler
changed the title
Property types improvements
Plugin Property types improvements
Nov 24, 2021
@pauloouriques - for compliance, we really do need everyone to fill out the PR template located here. Please copy this into your PR description and fill it out It's also nice to have a good description in the PR to remember why we made a certain change tied to a commit. |
evantahler
suggested changes
Nov 24, 2021
evantahler
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This pull request contains multiple property types improvements.
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review