Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Plugin Property types improvements #2568

Merged
merged 9 commits into from
Nov 30, 2021
Merged

Conversation

pauloouriques
Copy link
Contributor

@pauloouriques pauloouriques commented Nov 22, 2021

Change description

This pull request contains multiple property types improvements.

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@pauloouriques pauloouriques added enhancement New feature or request plugin labels Nov 22, 2021
Copy link
Member

@bleonard bleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misunderstanding about date vs. datetime concepts. trying to clarify.

@evantahler evantahler changed the title Property types improvements Plugin Property types improvements Nov 24, 2021
@evantahler
Copy link
Member

evantahler commented Nov 24, 2021

@pauloouriques - for compliance, we really do need everyone to fill out the PR template located here. Please copy this into your PR description and fill it out It's also nice to have a good description in the PR to remember why we made a certain change tied to a commit.

@pauloouriques pauloouriques merged commit ba59dc5 into main Nov 30, 2021
@pauloouriques pauloouriques deleted the feature/destinations-types branch November 30, 2021 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants