This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 117
Config & Config UI for App Refresh Query #2570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teallarson
force-pushed
the
180382146-configui-refreshQuery
branch
2 times, most recently
from
November 24, 2021 15:10
60cfff2
to
12d4e59
Compare
evantahler
reviewed
Nov 24, 2021
teallarson
commented
Nov 24, 2021
teallarson
force-pushed
the
180382146-configui-refreshQuery
branch
from
November 29, 2021 15:11
62fc431
to
dc737f7
Compare
@evantahler one question on this PR... I'm not sure that there are customers using an app refresh query in production, but if there were, this would be breaking I believe because of the rename. How do we do migrations for code config? |
I think that for expediency's sake, it's a safe assumption that folks are not yet using code-config (as we haven't announced it yet). I wouldn't focus on a code-config migration at this time. @bleonard - does that work for you? |
krishnaglick
approved these changes
Nov 30, 2021
Co-authored-by: Evan Tahler <evan.tahler@grouparoo.com>
teallarson
force-pushed
the
180382146-configui-refreshQuery
branch
from
November 30, 2021 15:01
2a42b9b
to
648ad07
Compare
evantahler
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
appRefreshQuery.locked
andapp.locked
appRefreshQuery:run
task is enqueued immediately if the query is updated on the modelNew Config UI for App Refresh Query:
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review