Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Config & Config UI for App Refresh Query #2570

Merged
merged 14 commits into from
Nov 30, 2021

Conversation

teallarson
Copy link
Contributor

@teallarson teallarson commented Nov 23, 2021

Change description

  • config files now use the structure:
  "refresh" : {
    "query": "...",
    "recurringFrequency": 60000
  }
  • Config UI fixes (don't show the currently saved values or "run" button, query gets saved to file correctly now)
  • Fixed UI to default to "Edit" state upon creating a new App Refresh Query. Also fixed issue with React intermittently locking the object for "undefined" values for appRefreshQuery.locked and app.locked
  • appRefreshQuery:run task is enqueued immediately if the query is updated on the model

New Config UI for App Refresh Query:
Screen Shot 2021-11-24 at 10 46 41 AM

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@teallarson teallarson force-pushed the 180382146-configui-refreshQuery branch 2 times, most recently from 60cfff2 to 12d4e59 Compare November 24, 2021 15:10
@teallarson teallarson added the enhancement New feature or request label Nov 24, 2021
@teallarson teallarson marked this pull request as ready for review November 24, 2021 15:48
core/__tests__/models/appRefreshQuery.ts Show resolved Hide resolved
core/src/models/App.ts Outdated Show resolved Hide resolved
ui/ui-components/pages/app/[id]/refresh.tsx Outdated Show resolved Hide resolved
core/src/models/App.ts Show resolved Hide resolved
ui/ui-components/pages/app/[id]/refresh.tsx Outdated Show resolved Hide resolved
ui/ui-components/pages/app/[id]/refresh.tsx Show resolved Hide resolved
ui/ui-components/pages/app/[id]/refresh.tsx Show resolved Hide resolved
@teallarson
Copy link
Contributor Author

@evantahler one question on this PR... I'm not sure that there are customers using an app refresh query in production, but if there were, this would be breaking I believe because of the rename. How do we do migrations for code config?

@evantahler
Copy link
Member

I think that for expediency's sake, it's a safe assumption that folks are not yet using code-config (as we haven't announced it yet). I wouldn't focus on a code-config migration at this time.

@bleonard - does that work for you?

@teallarson teallarson force-pushed the 180382146-configui-refreshQuery branch from 2a42b9b to 648ad07 Compare November 30, 2021 15:01
@teallarson teallarson merged commit 024c7f4 into main Nov 30, 2021
@teallarson teallarson deleted the 180382146-configui-refreshQuery branch November 30, 2021 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants