Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Do not show "Add Multiple Properties" if source is not ready #2575

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Do not show "Add Multiple Properties" if source is not ready #2575

merged 1 commit into from
Nov 29, 2021

Conversation

evantahler
Copy link
Member

@evantahler evantahler commented Nov 24, 2021 •
edited

Screen Shot 2021-11-24 at 3 24 27 PM

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@evantahler evantahler added the bug Something isn't working label Nov 24, 2021
teallarson
teallarson approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@evantahler evantahler merged commit 0fb5e17 into main Nov 29, 2021
@evantahler evantahler deleted the 180413893-hide-multiple-properties-button-until-ready branch November 29, 2021 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teallarson teallarson teallarson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evantahler @teallarson