Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Salesforce float recordMatchField issue #2576

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Salesforce float recordMatchField issue #2576

merged 4 commits into from
Dec 1, 2021

Conversation

pauloouriques
Copy link
Contributor

@pauloouriques pauloouriques commented Nov 26, 2021 •
edited

Change description

This PR inserts the code responsible for parsing to Number the Salesforce foreignKeys if the recordMatchField was float, integer, or double.

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@pauloouriques pauloouriques added bug Something isn't working plugin labels Nov 26, 2021
@pauloouriques pauloouriques force-pushed the fix/salesforce-float-record-match-field branch from 35f133d to c273652 Compare December 1, 2021 20:07
@bleonard bleonard merged commit 129e595 into main Dec 1, 2021
@bleonard bleonard deleted the fix/salesforce-float-record-match-field branch December 1, 2021 22:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bleonard bleonard bleonard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pauloouriques @bleonard