This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Ignore null/undefined config objects and return a useful error about the file with the problem #2633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
to the config fileThis PR also changes config object writing (specifically for records, but it may apply in the future to other config types). This allows for merging config objects that share a destination filepath.
What this allows us to do is break out
Record
config files on a per-model basisBefore:
After:
Thanks to @rwfeather!
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review