This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Import all Sample Profiles #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
commented
Dec 3, 2021
| api.codeConfig.allowLockedModelChanges = false; // after this point in the Actionhero boot lifecycle, locked models cannot be changed | ||
| await loadSampleProfiles(); |
There was a problem hiding this comment.
The story called for this to not be awaited and run in the "background". However, I'm concerned about creating parallel queries when using SQLite (which ui-config is guaranteed to be using).
At the very least, we now are using a "regular" Initializer, not CLSInitializer so failures are OK and the transaction won't be polluted by an import failure here.
There was a problem hiding this comment.
That's a good point but I'm also worried it might take a while to launch.
At a minimum, let's log before we do that so it's clear what is happening on the console.
krishnaglick
reviewed
Dec 3, 2021
krishnaglick
approved these changes
Dec 3, 2021
|
This has conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Button in
ui-configto import all sample Records.Also automatically tries to pre-load all the existing sample records at boot when using
ui-cofigChecklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review