oAuth user sign in #2667
oAuth user sign in #2667
Conversation
| router.replace( | ||
| `/object/${response.oAuthRequest.appId}?requestId=${requestId}&appOption=${response.oAuthRequest.appOption}` | ||
| ); |
There was a problem hiding this comment.
This is a bit WIP until we have an app to authenticate against, but it will be something like this
| </Col> | ||
| </Row> | ||
|
|
||
| <Modal show={showModal} onHide={() => setShowModal(false)}> |
There was a problem hiding this comment.
In the case you have more than one identity, we show a modal so you can pick the right one
| // TODO: How can we test this without making real oAuth requests? | ||
| test.todo("an oAuth token and identities can be retrieved"); |
There was a problem hiding this comment.
Just like in the telemetry app, we need to come up with a pattern to test a full oAuth flow...
evantahler
force-pushed
the
180364935-oauth
branch
from
7e45a2f
to
733c31a
Compare
core/src/actions/session.ts
Outdated
| const oauthRequest = await OAuthRequest.findOne({ | ||
| where: { id: params.requestId }, | ||
| }); |
There was a problem hiding this comment.
If this matches we should also delete the OAuthRequest or set something on it so it can't be used again. At the moment the requestId can be reused (until it's swept)
There was a problem hiding this comment.
👍 Love it. Thank you for reading all this code so carefully! Updated in e2ad6c6
evantahler
force-pushed
the
180364935-oauth
branch
2 times, most recently
from
320d204
to
e21ede5
Compare
|
Ok @pedroslopez I've got login reuse fixed up, and telemetry deployed. I think this is ready to go! |
|
Milestone! The production |
| throw new Errors.AuthenticationError("password does not match"); | ||
| } else { | ||
| const oauthRequest = await OAuthRequest.findOne({ | ||
| where: { id: params.requestId, consumed: false }, |
There was a problem hiding this comment.
It feels a little odd that the identities are still returned to the user for a consumed oauth request (going to /session/sign-in?requestId=req_ABCDE), but it's probably ok
There was a problem hiding this comment.
That's a good idea! 857d687 prevents showing identities for consumed oAuth requests
evantahler
force-pushed
the
180364935-oauth
branch
from
b86fe74
to
857d687
Compare
Users can sign into Grouparoo instances with oAuth
oAuth.mov
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review