Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Move Toasts to bottom right and show close button #2676

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

evantahler
Copy link
Member

@evantahler evantahler commented Dec 13, 2021

Following after #2675, this PR moves the Toasts to the bottom right of the viewport and shows a close button

Screen Shot 2021-12-13 at 10 16 26 AM

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@evantahler evantahler added the enhancement New feature or request label Dec 13, 2021
@evantahler evantahler enabled auto-merge (squash) December 13, 2021 18:19
@@ -171,7 +171,7 @@ export default function Main(props) {
<div
style={{
position: "fixed",
top: 0,
bottom: 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, it looks like a Toast.Container can handle it for us. Unless we're avoiding that for some specific reason?
https://react-bootstrap.github.io/components/toasts/#toast-container-props

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that exists in react-bootsrap v1 (bootstrap 4) which we are still using in core

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM - ToastConatiner is not in the version we are using https://react-bootstrap-v4.netlify.app/components/toasts/

@evantahler evantahler merged commit f8357af into main Dec 14, 2021
@evantahler evantahler deleted the 180481500-toasty-move branch December 14, 2021 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants