This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Remove Manual Groups #2681
Merged
Remove Manual Groups #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
added
enhancement
7 tasks
evantahler
commented
Dec 16, 2021
Comment on lines
+46
to
+56
| @Column(DataType.STRING) | ||
| op: GroupRuleOpType; | ||
|
|
||
| @Column | ||
| relativeMatchNumber: number; | ||
|
|
||
| @Column | ||
| relativeMatchUnit: string; | ||
| @Column(DataType.STRING) | ||
| relativeMatchUnit: RelativeMatchUnitType; | ||
|
|
||
| @Column | ||
| relativeMatchDirection: string; | ||
| @Column(DataType.STRING) | ||
| relativeMatchDirection: RelativeMatchDirectionType; |
Comment on lines
+58
to
+62
| operation: { op: GroupRuleOpType; description?: string }; | ||
| match?: string | number | boolean; | ||
| relativeMatchNumber?: number; | ||
| relativeMatchUnit?: string; | ||
| relativeMatchDirection?: string; | ||
| relativeMatchUnit?: RelativeMatchUnitType; | ||
| relativeMatchDirection?: RelativeMatchDirectionType; |
|
|
||
| export async function loadGroup( | ||
| configObject: GroupConfigurationObject, | ||
| externallyValidate: boolean, | ||
| validate = false | ||
| ): Promise<IdsByClass> { | ||
| let isNew = false; | ||
| validateConfigObjectKeys(Group, configObject, ["rules"]); | ||
| validateConfigObjectKeys(Group, configObject, ["rules", "type"]); |
There was a problem hiding this comment.
For now, we won't crash if group.type is provided on a config object, but we check it below
Comment on lines
+103
to
+110
| export type GroupRuleOpType = | ||
| | typeof _boolean_ops[number]["op"] | ||
| | typeof _number_ops[number]["op"] | ||
| | typeof _string_ops_sqlite[number]["op"] | ||
| | typeof _string_ops_postgres[number]["op"] | ||
| | typeof _date_ops[number]["op"]; | ||
| export type RelativeMatchUnitType = typeof _relativeMatchUnits[number]; | ||
| export type RelativeMatchDirectionType = "add" | "subtract"; |
There was a problem hiding this comment.
Finally providing types for the Group Rules
pedroslopez
approved these changes
Dec 17, 2021
teallarson
approved these changes
Dec 17, 2021
Co-authored-by: Teal Larson <teal.larson@grouparoo.com>
evantahler
force-pushed
the
179691483-remove-manual-groups
branch
from
5add42a
to
94ed466
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify & clarify Grouparoo, this PR removes the concept of "manual" Groups. From this point forward, all Grouparoo Groups are "calculated", meaning that they dynamically determine which Records are members based on the Properties of those Records. This has the effect of simplifying many things from the UI, configuration files, and internal logic. This is a breaking change.
After the application of this PR, the following breaking changes will happen:
group.typeis no longer a property of a Grouparoo group.Docs @ grouparoo/www.grouparoo.com#828
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review