This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Replace Destination data page Record Preview with Sample Record Card #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
approved these changes
Dec 15, 2021
| : "None"} | ||
| </p> | ||
| } | ||
| <h6>{groupsTitle}</h6> |
There was a problem hiding this comment.
Nice - I really like how reusable you made this component. It's gnarly, but it's very powerful.
Comment on lines
+507
to
+510
| <FontAwesomeIcon | ||
| icon="times" | ||
| fixedWidth | ||
| /> |
There was a problem hiding this comment.
Yeah, that's probably better than ❌
edmundito
force-pushed
the
180254221-destination-sample-record
branch
from
5198b12
to
ff6cc31
Compare
* Update Sample record card to render destiantion record preview groups * Add support to disable propertyLink, import button * Add customizable properties and groups title * Add loading / unavailable state
…ithout record id for destination fetcher
…orted * Update Managed card to set border style * Update SampleRecord to accept "warning" * Update "Switch to random Record" button text to "Load Random Record" * Update Destination page drop down from No Group or Model to No Model or Group
…ge and disable button
edmundito
force-pushed
the
180254221-destination-sample-record
branch
from
ff6cc31
to
cf125cd
Compare
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Replace the RecordPreview Component with the Destination Sample Record. This is a followup to to #2616 and #2677.
The sample record for the destination will show what the record will look like at the destination, compared to the model/property sample records which come from the source. In order to do this, a lot of customizations had to be added to the Sample Record card so that it can support both data types.
When the destination is still being set up, the record will show an empty state:
When the record will not end in the destination it will show a warning:
In smaller window sizes, the sample record will show below all the destination set up.
Bonus: Disable the import record button in the property sample record as indicated by our story.
TODO:
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review