This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Rebuild state from props when changing from one property edit page to another #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundito
reviewed
Dec 21, 2021
|
|
||
| useEffect(() => { | ||
| updatePluginOptions(); | ||
|
|
||
| return () => { | ||
| clearTimeout(timer); | ||
| }; | ||
| }, [JSON.stringify(property.options)]); | ||
| }, [property.id, JSON.stringify(property.options)]); |
There was a problem hiding this comment.
What's the difference between propertyId above and property.id?
There was a problem hiding this comment.
I think this hook wants to be called after property is set, which the previous hook will do after the URL (propertyID) changes
edmundito
approved these changes
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when using the new Property Preview widget when switching from one property page to another. We store the initial page props in local state variables (so they can be edited by the user), and we need to reset those with the new props.
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review