This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
enable group members page on community edition #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroslopez
commented
Dec 22, 2021
evantahler
suggested changes
Dec 23, 2021
Comment on lines
+10
to
+13
| case "community": | ||
| tabs = ["members"]; | ||
| defaultTab = "members"; | ||
| break; |
There was a problem hiding this comment.
I think this means that community lost edit and rules, which it used to have
There was a problem hiding this comment.
It didn't have any pages previously - this GroupTabs component was returning edit and rules by default because community wasn't using GroupTabs at all. If you'll notice the /pages/model/[modelId]/group dir for ui-community, it didn't exist before and members was just added now.
evantahler
approved these changes
Dec 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Adds the group members page to Grouparoo Community Edition.
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review