Package.json validation tests

[teallarson]

Change description

• Adds schema validation tests for our Package.json files
• Checks for version matches across the repo
• Checks file contents for items in our "bad words" list

Went with invoking the version checker and spelling checker within child process inside the jest test as the scripts in place did a more efficient job of the tasks then a JavaScript solution would in my opinion.

Also removed the CI jobs that used to execute those scripts, and added one to run the new suite.

Checklists

Development

• Application changes have been tested appropriately

Impact

• Code follows company security practices and guidelines
• Security impact of change has been considered
• Performance impact of change has been considered
• Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

• Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
• Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

[teallarson]

the flaky test here in models is fixed by #2943 (missing awaits)

[evantahler]

Good setup! I like the consistency of having a top-level test suite, rather then some random bash scripts we run.

I think there are a few topics to look into:

1. Don't import/require anything from grouparoo/core or grouparoo/spec-helper. They shouldn't be needed and I'm worried that will have an adverse effect on the publishing pipeline
2. Can JSON-schema assert the contents of the JSON rather than the types? For example, we don't really care that publish config is /any/ string in the packages, we really do want to assert that it is "public". I think that's a better reflection of the goal.

[evantahler]

Same as below - an early reject without a return will still also resolve later

[krishnaglick]

I think doing done(error || stderr) and not wrapping all this in a promise may be the best way to handle it.

[teallarson]

Went with the done() pattern for both the version and license checkers and piped out the most meaningful messaging for each checker (license checker shows it in stderr, but the version checker shows it in stdout)

[teallarson]

Changes since last review:

• Tighter assertions for the publishConfig (Implemented by adding a third schema for restricted access configs and switching some logic for which schema to use. The only packages using the schemaGeneric now are ones that do not require a publishConfig.)
• Tighter assertion for engine
• TSConfig and CI Job cleanup
• Tests for version and license checking fail correctly now, and display helpful errors (ie: what package it failed on and why)