Hubspot contact and company association #2947
Conversation
pauloouriques
force-pushed
the
feature/hubspot-contact-company-association
branch
from
24ff2b8
to
80b06f4
Compare
| key: "companyKey", | ||
| displayName: "Company Key", | ||
| required: false, | ||
| description: "Which field in the Company uniquely represents it?", |
There was a problem hiding this comment.
If companyKey is optional, what will be used by default? We might want to mention the email domain will be used if this is not set.
There was a problem hiding this comment.
If companyKey is not set the relationship is just ignored.
There was a problem hiding this comment.
But doesn't hubspot make companies autoamtically from the email domain? Either way, 👍
There was a problem hiding this comment.
This could say something like "Links a Contact to a company by something other than the Hubspot default (email domain)."
There was a problem hiding this comment.
ahh! Now I got what you're saying @evantahler, thank you. Brian's text will do the trick.
| key: "companyKey", | ||
| displayName: "Company Key", | ||
| required: false, | ||
| description: "Which field in the Company uniquely represents it?", |
There was a problem hiding this comment.
This could say something like "Links a Contact to a company by something other than the Hubspot default (email domain)."
plugins/@grouparoo/hubspot/src/lib/export-contacts/destinationMappingOptions.ts
Outdated
Show resolved
Hide resolved
plugins/@grouparoo/hubspot/src/lib/export-contacts/exportRecord.ts
Outdated
Show resolved
Hide resolved
- include interger to destination options mapping type; - add test companies; - change destination option description; - skip anything that starts with Company.
Change description
This PR makes it possible to associate a contact to a company and also adds all re required tests to cover that new feature.
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review