Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Google Sheets Destination: lock other threads while adding new records #2951

Merged
merged 6 commits into from Feb 9, 2022

Conversation

pauloouriques
Copy link
Contributor

@pauloouriques pauloouriques commented Feb 8, 2022

Change description

This PR adds the lock to avoid 2 threads adding records at the same time.

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@pauloouriques pauloouriques added bug Something isn't working plugin labels Feb 8, 2022
Copy link
Member

@bleonard bleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes, but 🟢 assuming you've tested a few threads at once in the UI.

@pauloouriques pauloouriques merged commit ad7d44f into main Feb 9, 2022
@pauloouriques pauloouriques deleted the fix/google-sheets-destination branch February 9, 2022 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants