Add subnav items under each model #2953
Conversation
Screen.Recording.2022-02-09.at.9.26.36.AM.mov |
| { | ||
| type: "link", | ||
| title: "Records", | ||
| icon: "file-alt", | ||
| href: `/model/${model.id}/records`, | ||
| mainPathSectionIdx: 3, | ||
| small: true, | ||
| }, |
There was a problem hiding this comment.
👍 I like that this goes to the list page
| {childNav.title === "Runs" ? ( | ||
| <> | ||
| {" "} | ||
| <RunningRunsBadge /> |
There was a problem hiding this comment.
Oh! I guess we had lost this badge
There was a problem hiding this comment.
Actually, this logic is still in the parent component: https://github.com/grouparoo/grouparoo/pull/2953/files#diff-f356a14f3edf616238baef014100f4a869eaa21d8bbf00df34305b2b420d3066L194
It got added here due to copy-paste, but after taking a second look it seems unnecessary to include it here. This code path handles the subNav items only, and since the "Runs" nav item is handled as a top level item behind the accordion, it doesn't really need to be here.
| icon: string; | ||
| mainPathSectionIdx: number; | ||
| small: boolean; | ||
| navChildItems?: NavigationItem[]; |
There was a problem hiding this comment.
Nit: Maybe subNavItems ?
|
I noticed in the video and confirmed in my local checkout as well that when navigating from the model's records to destinations it doesn't land in the right spot. It looks like the sample record is dynamically loading there instead of hydrating from getServerSideProps. Also, I wonder if there is a way to enable smooth scrolling on the page after the first load, but nothing too complicated. maybe something simple based on this suggestion: https://stackoverflow.com/a/61784812/20494 |
Looks like I created this branch before #2941 landed in |
rwfeather
force-pushed
the
180984300-model-links-nav
branch
from
fc24051
to
52fd909
Compare
|
Loading behavior looks better. I'm currently working on adding the smooth scrolling. |
rwfeather
force-pushed
the
180984300-model-links-nav
branch
from
8267091
to
ba273e2
Compare
Change description
Adds new navigation items underneath the active model
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review