This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Move monorepo tests into sub-project #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the new test running OK - https://app.circleci.com/pipelines/github/grouparoo/grouparoo/15314/workflows/3e4cb225-a789-46c9-b3c9-2c9f5ecd3d9e/jobs/430622 |
teallarson
approved these changes
Feb 10, 2022
| console.log("[syncpack]: " + stdout); | ||
| if (err || stderr) { | ||
| console.error(err || stderr); | ||
| throw new Error("syncpack error"); |
There was a problem hiding this comment.
Note that the useful information (which packages are mismatched) will be in stdout not err or stderr.
There was a problem hiding this comment.
ah-ha! I'll add that back.
There was a problem hiding this comment.
Actually, it seems to be OK as-is. I changed one of the versions of jest and the test failed:
@evantahler ➜ /workspaces/grouparoo/monorepo (main ✗) $ npm test
> @grouparoo/monorepo@0.0.0 test
> jest
console.log
[syncpack]: - jest 27.5.1
27.5.0 in devDependencies of @grouparoo/monorepo
27.5.1 in devDependencies of @grouparoo/core
27.5.1 in devDependencies of @grouparoo/app-staging-community
27.5.1 in devDependencies of @grouparoo/app-staging-config
27.5.1 in devDependencies of @grouparoo/app-staging-enterprise
27.5.1 in devDependencies of @grouparoo/airtable
27.5.1 in devDependencies of @grouparoo/app-templates
27.5.1 in devDependencies of @grouparoo/bigquery
27.5.1 in devDependencies of @grouparoo/braze
27.5.1 in devDependencies of @grouparoo/calculated-property
27.5.1 in devDependencies of @grouparoo/clickhouse
27.5.1 in devDependencies of @grouparoo/closeio
27.5.1 in devDependencies of @grouparoo/cloudwatch
27.5.1 in devDependencies of @grouparoo/csv
27.5.1 in devDependencies of @grouparoo/customerio
27.5.1 in devDependencies of @grouparoo/dbt
27.5.1 in devDependencies of @grouparoo/demo
27.5.1 in devDependencies of @grouparoo/eloqua
27.5.1 in devDependencies of @grouparoo/facebook
27.5.1 in devDependencies of @grouparoo/google-sheets
27.5.1 in devDependencies of @grouparoo/hubspot
27.5.1 in devDependencies of @grouparoo/intercom
27.5.1 in devDependencies of @grouparoo/iterable
27.5.1 in devDependencies of @grouparoo/klaviyo
27.5.1 in devDependencies of @grouparoo/logger
27.5.1 in devDependencies of @grouparoo/mailchimp
27.5.1 in devDependencies of @grouparoo/mailjet
27.5.1 in devDependencies of @grouparoo/marketo
27.5.1 in devDependencies of @grouparoo/mixpanel
27.5.1 in devDependencies of @grouparoo/mongo
27.5.1 in devDependencies of @grouparoo/mysql
27.5.1 in devDependencies of @grouparoo/newrelic
27.5.1 in devDependencies of @grouparoo/onesignal
27.5.1 in devDependencies of @grouparoo/pardot
27.5.1 in devDependencies of @grouparoo/pipedrive
27.5.1 in devDependencies of @grouparoo/postgres
27.5.1 in devDependencies of @grouparoo/prometheus
27.5.1 in devDependencies of @grouparoo/redshift
27.5.1 in devDependencies of @grouparoo/rollbar
27.5.1 in devDependencies of @grouparoo/sailthru
27.5.1 in devDependencies of @grouparoo/salesforce
27.5.1 in devDependencies of @grouparoo/sendgrid
27.5.1 in devDependencies of @grouparoo/sentry
27.5.1 in devDependencies of @grouparoo/snowflake
27.5.1 in devDependencies of @grouparoo/spec-helper
27.5.1 in devDependencies of @grouparoo/sqlite
27.5.1 in devDependencies of @grouparoo/vero
27.5.1 in devDependencies of @grouparoo/zendesk
27.5.1 in devDependencies of @grouparoo/ui-community
27.5.1 in devDependencies of @grouparoo/ui-components
27.5.1 in devDependencies of @grouparoo/ui-config
27.5.1 in devDependencies of @grouparoo/ui-enterprise
at __tests__/packages.ts:120:17
console.error
Error: Command failed: ./node_modules/.bin/syncpack list-mismatches
at ChildProcess.exithandler (node:child_process:397:12)
at ChildProcess.emit (node:events:390:28)
at maybeClose (node:internal/child_process:1064:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5) {
killed: false,
code: 1,
signal: null,
cmd: './node_modules/.bin/syncpack list-mismatches'
}
120 | console.log("[syncpack]: " + stdout);
121 | if (err || stderr) {
> 122 | console.error(err || stderr);
| ^
123 | throw new Error("syncpack error");
124 | }
125 | done();
at __tests__/packages.ts:122:19
There was a problem hiding this comment.
Actually, it seems to be OK as-is. I changed one of the versions of jest and the test failed:
@evantahler ➜ /workspaces/grouparoo/monorepo (main ✗) $ npm test > @grouparoo/monorepo@0.0.0 test > jest console.log [syncpack]: - jest 27.5.1 27.5.0 in devDependencies of @grouparoo/monorepo 27.5.1 in devDependencies of @grouparoo/core 27.5.1 in devDependencies of @grouparoo/app-staging-community 27.5.1 in devDependencies of @grouparoo/app-staging-config 27.5.1 in devDependencies of @grouparoo/app-staging-enterprise 27.5.1 in devDependencies of @grouparoo/airtable 27.5.1 in devDependencies of @grouparoo/app-templates 27.5.1 in devDependencies of @grouparoo/bigquery 27.5.1 in devDependencies of @grouparoo/braze 27.5.1 in devDependencies of @grouparoo/calculated-property 27.5.1 in devDependencies of @grouparoo/clickhouse 27.5.1 in devDependencies of @grouparoo/closeio 27.5.1 in devDependencies of @grouparoo/cloudwatch 27.5.1 in devDependencies of @grouparoo/csv 27.5.1 in devDependencies of @grouparoo/customerio 27.5.1 in devDependencies of @grouparoo/dbt 27.5.1 in devDependencies of @grouparoo/demo 27.5.1 in devDependencies of @grouparoo/eloqua 27.5.1 in devDependencies of @grouparoo/facebook 27.5.1 in devDependencies of @grouparoo/google-sheets 27.5.1 in devDependencies of @grouparoo/hubspot 27.5.1 in devDependencies of @grouparoo/intercom 27.5.1 in devDependencies of @grouparoo/iterable 27.5.1 in devDependencies of @grouparoo/klaviyo 27.5.1 in devDependencies of @grouparoo/logger 27.5.1 in devDependencies of @grouparoo/mailchimp 27.5.1 in devDependencies of @grouparoo/mailjet 27.5.1 in devDependencies of @grouparoo/marketo 27.5.1 in devDependencies of @grouparoo/mixpanel 27.5.1 in devDependencies of @grouparoo/mongo 27.5.1 in devDependencies of @grouparoo/mysql 27.5.1 in devDependencies of @grouparoo/newrelic 27.5.1 in devDependencies of @grouparoo/onesignal 27.5.1 in devDependencies of @grouparoo/pardot 27.5.1 in devDependencies of @grouparoo/pipedrive 27.5.1 in devDependencies of @grouparoo/postgres 27.5.1 in devDependencies of @grouparoo/prometheus 27.5.1 in devDependencies of @grouparoo/redshift 27.5.1 in devDependencies of @grouparoo/rollbar 27.5.1 in devDependencies of @grouparoo/sailthru 27.5.1 in devDependencies of @grouparoo/salesforce 27.5.1 in devDependencies of @grouparoo/sendgrid 27.5.1 in devDependencies of @grouparoo/sentry 27.5.1 in devDependencies of @grouparoo/snowflake 27.5.1 in devDependencies of @grouparoo/spec-helper 27.5.1 in devDependencies of @grouparoo/sqlite 27.5.1 in devDependencies of @grouparoo/vero 27.5.1 in devDependencies of @grouparoo/zendesk 27.5.1 in devDependencies of @grouparoo/ui-community 27.5.1 in devDependencies of @grouparoo/ui-components 27.5.1 in devDependencies of @grouparoo/ui-config 27.5.1 in devDependencies of @grouparoo/ui-enterprise at __tests__/packages.ts:120:17 console.error Error: Command failed: ./node_modules/.bin/syncpack list-mismatches at ChildProcess.exithandler (node:child_process:397:12) at ChildProcess.emit (node:events:390:28) at maybeClose (node:internal/child_process:1064:16) at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5) { killed: false, code: 1, signal: null, cmd: './node_modules/.bin/syncpack list-mismatches' } 120 | console.log("[syncpack]: " + stdout); 121 | if (err || stderr) { > 122 | console.error(err || stderr); | ^ 123 | throw new Error("syncpack error"); 124 | } 125 | done(); at __tests__/packages.ts:122:19
Oh awesome!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves our internal monorepo-level tests to a subproject. This will reduce the dependencies required at the root-level of the project, and help make staging deploys that /have/ to run
npm installwork again maybeDevelopment Notes
I'm doing local testing against sentry.
roo demo -cl- make some data with multiple sources and a destinationSENTRY_DSN=-xxxandSENTRY_TRACE_SAMPLE_RATE=1.0roo runChecklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review