Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Add new postgres query sources to demo command #2973

Merged
merged 4 commits into from Feb 21, 2022

Conversation

rwfeather
Copy link
Contributor

@rwfeather rwfeather commented Feb 15, 2022

Change description

This includes more configured properties when running the demo CLI

We didn't have an query-based sources, so this adds a few.

Since these new config objects are going to be specific to the source and the source database, I've included them under a postgres/{source} directory.

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@rwfeather rwfeather force-pushed the 181174952-postgres-demo-query-source branch from f1c5c04 to 9a80274 Compare February 16, 2022 19:42
@rwfeather rwfeather changed the title Add new query sources to demo command Add new postgres query sources to demo command Feb 21, 2022
@rwfeather rwfeather added the enhancement New feature or request label Feb 21, 2022
@rwfeather rwfeather merged commit 47b9624 into main Feb 21, 2022
@rwfeather rwfeather deleted the 181174952-postgres-demo-query-source branch February 21, 2022 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants